Skip to content

Remove echo usage in topic evaluation#12112

Merged
LouisLeNezet merged 26 commits into
nf-core:masterfrom
LouisLeNezet:fix_version
Jun 23, 2026
Merged

Remove echo usage in topic evaluation#12112
LouisLeNezet merged 26 commits into
nf-core:masterfrom
LouisLeNezet:fix_version

Conversation

@LouisLeNezet

Copy link
Copy Markdown
Contributor

PR checklist

echo command is not necessary when emitting the version of a tool.
The version of tools not emitting the version through cli, should be passed with val('X.X.X') instead of eval("echo X.X.X")

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet LouisLeNezet self-assigned this Jun 19, 2026
Comment thread modules/nf-core/ataqv/ataqv/main.nf
Comment thread modules/nf-core/clusty/main.nf
@LouisLeNezet LouisLeNezet requested review from a team as code owners June 23, 2026 10:02
Comment thread .nf-core.yml Outdated
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@LouisLeNezet LouisLeNezet added this pull request to the merge queue Jun 23, 2026
Merged via the queue into nf-core:master with commit 5909fc0 Jun 23, 2026
131 of 133 checks passed
@LouisLeNezet LouisLeNezet deleted the fix_version branch June 23, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants